Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated functions #764

Merged
merged 20 commits into from
Nov 21, 2023
Merged

Update deprecated functions #764

merged 20 commits into from
Nov 21, 2023

Conversation

JakeHartnell
Copy link
Member

Builds off of #762 and #763.

Closes #761

This was referenced Nov 11, 2023
Closed
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (db42d45) 96.25% compared to head (bad313e) 95.78%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           development     #764      +/-   ##
===============================================
- Coverage        96.25%   95.78%   -0.48%     
===============================================
  Files              203      203              
  Lines            50082    50344     +262     
===============================================
+ Hits             48207    48222      +15     
- Misses            1875     2122     +247
Files Coverage Δ
contracts/dao-dao-core/src/tests.rs 99.96% <100.00%> (-0.04%) ⬇️
contracts/external/cw-admin-factory/src/tests.rs 100.00% <100.00%> (ø)
...racts/external/cw-fund-distributor/src/contract.rs 95.06% <100.00%> (ø)
...-fund-distributor/src/testing/adversarial_tests.rs 100.00% <100.00%> (ø)
.../external/cw-fund-distributor/src/testing/tests.rs 100.00% <100.00%> (ø)
contracts/external/cw-payroll-factory/src/tests.rs 100.00% <100.00%> (ø)
contracts/external/cw-token-swap/src/contract.rs 99.41% <100.00%> (ø)
contracts/external/cw-token-swap/src/state.rs 97.75% <100.00%> (-2.25%) ⬇️
contracts/external/cw-token-swap/src/tests.rs 100.00% <100.00%> (ø)
contracts/external/cw-vesting/src/tests.rs 100.00% <100.00%> (ø)
... and 58 more

... and 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bekauz
bekauz approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@bekauz bekauz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one conflict

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (329b59a) 96.31% compared to head (136ae78) 96.31%.
Report is 1 commits behind head on development.

❗ Current head 136ae78 differs from pull request most recent head 2ce30b5. Consider uploading reports for the commit 2ce30b5 to get more accurate results

Files Patch % Lines
...racts/test/dao-test-custom-factory/src/contract.rs 44.82% 16 Missing ⚠️
...ts/external/cw-tokenfactory-issuer/src/contract.rs 0.00% 13 Missing ⚠️
...cts/voting/dao-voting-token-staked/src/contract.rs 50.00% 12 Missing ⚠️
...l/dao-proposal-multiple/src/testing/instantiate.rs 61.11% 7 Missing ⚠️
...tracts/external/cw-payroll-factory/src/contract.rs 58.33% 5 Missing ⚠️
contracts/test/dao-proposal-sudo/src/contract.rs 25.00% 3 Missing ⚠️
...ntracts/external/dao-migrator/src/testing/setup.rs 84.61% 2 Missing ⚠️
contracts/dao-dao-core/src/contract.rs 95.65% 1 Missing ⚠️
contracts/external/cw-vesting/src/contract.rs 85.71% 1 Missing ⚠️
...se/dao-pre-propose-approval-single/src/contract.rs 96.42% 1 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@               Coverage Diff               @@
##           development     #764      +/-   ##
===============================================
- Coverage        96.31%   96.31%   -0.01%     
===============================================
  Files              203      203              
  Lines            50058    50077      +19     
===============================================
+ Hits             48213    48230      +17     
- Misses            1845     1847       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (development@30337ad). Click here to learn what that means.

Additional details and impacted files 
@@              Coverage Diff               @@
##             development     #764   +/-   ##
==============================================
  Coverage               ?   96.31%           
==============================================
  Files                  ?      203           
  Lines                  ?    50092           
  Branches               ?        0           
==============================================
  Hits                   ?    48245           
  Misses                 ?     1847           
  Partials               ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bekauz bekauz merged commit 6ca751c into development Nov 21, 2023
9 checks passed
@bekauz bekauz deleted the update-deprecated-functions branch November 21, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekauz bekauz bekauz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deprecated function names to_binary and from_binary
4 participants
@JakeHartnell @bekauz @Massvdev @Dat-Andre